Skip to content

Conversation

@Dosant
Copy link
Contributor

@Dosant Dosant commented Sep 23, 2020

Backports the following commits to 7.x:

This pr makes sure there is way to disable URL drilldown feature.
I decided to extract Url drilldown definition into a separate plugin to benefit from regular disabling a plugin feature.
Having it as a separate plugin also makes sense because we will start adding registries specific to URL drilldown implementation

Co-authored-by: Elastic Machine <[email protected]>
@Dosant Dosant added the backport This PR is a backport of another PR label Sep 23, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
embeddableEnhanced 11 -5 16
urlDrilldown 8 +8 -
total +3

page load bundle size

id value diff baseline
embeddableEnhanced 25.5KB -14.8KB 40.4KB
uiActions 221.0KB +109.0B 220.9KB
uiActionsEnhanced 380.5KB +420.0B 380.1KB
urlDrilldown 18.7KB +18.7KB -
total +4.4KB

distributable file count

id value diff baseline
default 47663 +4 47659

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit d35dfb0 into elastic:7.x Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants